Re: [PATCH 4/6] sysctl: make proc_put_long() use scnprintf

From: Christoph Hellwig
Date: Tue Sep 01 2020 - 11:16:04 EST


On Thu, Aug 13, 2020 at 05:04:09PM -0400, Josef Bacik wrote:
> Now that we're passing down a kernel buffer with enough space to account
> for an extra NULL terminator, go ahead and use scnprintf() to print out
> a long in proc_put_long(). count here includes NULL terminator slot in
> the buffer, so we will get the correct behavior we're looking for.
>
> Signed-off-by: Josef Bacik <josef@xxxxxxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>