Re: [PATCH v2 1/2] MAINTAINERS: Consolidate Analog Devices IIO entries and remove Beniamin Bia

[Andy Shevchenko]

On Wed, Sep 2, 2020 at 6:04 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> Emails to Beniamin Bia bounce with no such address so remove him from
> maintainers.  After this removal, many entries for Analog Devices Inc
> IIO drivers look exactly the same so consolidate them.
>

Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
But nit-pick below.

> Suggested-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Suggested-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> Cc: Michael Hennerich <Michael.Hennerich@xxxxxxxxxx>
> Cc: Jonathan Cameron <jic23@xxxxxxxxxx>
> Cc: linux-iio <linux-iio@xxxxxxxxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>
> ---
>
> Changes since v1:
> 1. Consolidate IIO entries
> ---
>  MAINTAINERS | 56 ++++-------------------------------------------------
>  1 file changed, 4 insertions(+), 52 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8107b3d5d6df..facffcf7b1d1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -950,38 +950,6 @@ S: Supported
>  F:     arch/arm64/boot/dts/amd/amd-seattle-xgbe*.dtsi
>  F:     drivers/net/ethernet/amd/xgbe/
>
> -ANALOG DEVICES INC AD5686 DRIVER
> -M:     Michael Hennerich <Michael.Hennerich@xxxxxxxxxx>
> -L:     linux-pm@xxxxxxxxxxxxxxx
> -S:     Supported
> -W:     http://ez.analog.com/community/linux-device-drivers
> -F:     drivers/iio/dac/ad5686*
> -F:     drivers/iio/dac/ad5696*
> -
> -ANALOG DEVICES INC AD5758 DRIVER
> -M:     Michael Hennerich <Michael.Hennerich@xxxxxxxxxx>
> -L:     linux-iio@xxxxxxxxxxxxxxx
> -S:     Supported
> -W:     http://ez.analog.com/community/linux-device-drivers
> -F:     Documentation/devicetree/bindings/iio/dac/ad5758.txt
> -F:     drivers/iio/dac/ad5758.c
> -
> -ANALOG DEVICES INC AD7091R5 DRIVER
> -M:     Beniamin Bia <beniamin.bia@xxxxxxxxxx>
> -L:     linux-iio@xxxxxxxxxxxxxxx
> -S:     Supported
> -W:     http://ez.analog.com/community/linux-device-drivers
> -F:     Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml
> -F:     drivers/iio/adc/ad7091r5.c
> -
> -ANALOG DEVICES INC AD7124 DRIVER
> -M:     Michael Hennerich <Michael.Hennerich@xxxxxxxxxx>
> -L:     linux-iio@xxxxxxxxxxxxxxx
> -S:     Supported
> -W:     http://ez.analog.com/community/linux-device-drivers
> -F:     Documentation/devicetree/bindings/iio/adc/adi,ad7124.yaml
> -F:     drivers/iio/adc/ad7124.c
> -
>  ANALOG DEVICES INC AD7192 DRIVER
>  M:     Alexandru Tachici <alexandru.tachici@xxxxxxxxxx>
>  L:     linux-iio@xxxxxxxxxxxxxxx
> @@ -998,15 +966,6 @@ W: http://ez.analog.com/community/linux-device-drivers
>  F:     Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml
>  F:     drivers/iio/adc/ad7292.c
>
> -ANALOG DEVICES INC AD7606 DRIVER
> -M:     Michael Hennerich <Michael.Hennerich@xxxxxxxxxx>
> -M:     Beniamin Bia <beniamin.bia@xxxxxxxxxx>
> -L:     linux-iio@xxxxxxxxxxxxxxx
> -S:     Supported
> -W:     http://ez.analog.com/community/linux-device-drivers
> -F:     Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> -F:     drivers/iio/adc/ad7606.c
> -
>  ANALOG DEVICES INC AD7768-1 DRIVER
>  M:     Michael Hennerich <Michael.Hennerich@xxxxxxxxxx>
>  L:     linux-iio@xxxxxxxxxxxxxxx
> @@ -1068,7 +1027,6 @@ F:        drivers/iio/imu/adis16475.c
>  F:     Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml
>
>  ANALOG DEVICES INC ADM1177 DRIVER
> -M:     Beniamin Bia <beniamin.bia@xxxxxxxxxx>
>  M:     Michael Hennerich <Michael.Hennerich@xxxxxxxxxx>
>  L:     linux-hwmon@xxxxxxxxxxxxxxx
>  S:     Supported
> @@ -1135,15 +1093,6 @@ S:       Supported
>  W:     http://ez.analog.com/community/linux-device-drivers
>  F:     drivers/dma/dma-axi-dmac.c
>
> -ANALOG DEVICES INC HMC425A DRIVER
> -M:     Beniamin Bia <beniamin.bia@xxxxxxxxxx>
> -M:     Michael Hennerich <michael.hennerich@xxxxxxxxxx>
> -L:     linux-iio@xxxxxxxxxxxxxxx
> -S:     Supported
> -W:     http://ez.analog.com/community/linux-device-drivers
> -F:     Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml
> -F:     drivers/iio/amplifiers/hmc425a.c
> -
>  ANALOG DEVICES INC IIO DRIVERS
>  M:     Lars-Peter Clausen <lars@xxxxxxxxxx>
>  M:     Michael Hennerich <Michael.Hennerich@xxxxxxxxxx>
> @@ -1152,8 +1101,12 @@ W:       http://wiki.analog.com/
>  W:     http://ez.analog.com/community/linux-device-drivers
>  F:     Documentation/ABI/testing/sysfs-bus-iio-frequency-ad9523
>  F:     Documentation/ABI/testing/sysfs-bus-iio-frequency-adf4350

> +F:     Documentation/devicetree/bindings/iio/adc/adi*
> +F:     Documentation/devicetree/bindings/iio/amplifiers/adi*

I would rather see one line like
F:     Documentation/devicetree/bindings/iio/*/adi,*

Since we know that vendor,part-number is guaranteed by DT binding naming schema.

> +F:     Documentation/devicetree/bindings/iio/dac/ad5758.txt
>  F:     drivers/iio/*/ad*
>  F:     drivers/iio/adc/ltc249*
> +F:     drivers/iio/amplifiers/hmc425a.c
>  F:     drivers/staging/iio/*/ad*
>  X:     drivers/iio/*/adjd*
>
> @@ -16537,7 +16490,6 @@ F:      drivers/staging/rtl8712/
>
>  STAGING - SEPS525 LCD CONTROLLER DRIVERS
>  M:     Michael Hennerich <michael.hennerich@xxxxxxxxxx>
> -M:     Beniamin Bia <beniamin.bia@xxxxxxxxxx>
>  L:     linux-fbdev@xxxxxxxxxxxxxxx
>  S:     Supported
>  F:     Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> --
> 2.17.1
>


-- 
With Best Regards,
Andy Shevchenko