Re: [PATCH v2 1/2] MAINTAINERS: Consolidate Analog Devices IIO entries and remove Beniamin Bia

From: Krzysztof Kozlowski
Date: Wed Sep 02 2020 - 15:18:42 EST


On Wed, 2 Sep 2020 at 20:54, Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> On Wed, 2020-09-02 at 21:11 +0300, Andy Shevchenko wrote:
> > On Wed, Sep 2, 2020 at 6:04 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> > > Emails to Beniamin Bia bounce with no such address so remove him from
> > > maintainers. After this removal, many entries for Analog Devices Inc
> > > IIO drivers look exactly the same so consolidate them.
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> > But nit-pick below.
> []
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> []
> > > @@ -1152,8 +1101,12 @@ W: http://wiki.analog.com/
> > > W: http://ez.analog.com/community/linux-device-drivers
> > > F: Documentation/ABI/testing/sysfs-bus-iio-frequency-ad9523
> > > F: Documentation/ABI/testing/sysfs-bus-iio-frequency-adf4350
> > > +F: Documentation/devicetree/bindings/iio/adc/adi*
> > > +F: Documentation/devicetree/bindings/iio/amplifiers/adi*
> >
> > I would rather see one line like
> > F: Documentation/devicetree/bindings/iio/*/adi,*

Good point.

>
> Maybe the ones outside of iio too?
>
> $ find Documentation/ -wholename "*/adi,*"
> Documentation/devicetree/bindings/net/adi,adin.yaml
> Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml
> Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml
> Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
> Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml
> Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.txt
> Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml
> Documentation/devicetree/bindings/iio/adc/adi,ad7124.yaml
> Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml
> Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml
> Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml
> Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> Documentation/devicetree/bindings/iio/imu/adi,adis16480.txt
> Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml
> Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml
> Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> Documentation/devicetree/bindings/iio/accel/adi,adxl372.yaml
> Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt
> Documentation/devicetree/bindings/spi/adi,axi-spi-engine.txt
> Documentation/devicetree/bindings/sound/adi,adau7002.txt
> Documentation/devicetree/bindings/sound/adi,adau1977.txt
> Documentation/devicetree/bindings/sound/adi,adau7118.yaml
> Documentation/devicetree/bindings/sound/adi,axi-i2s.txt
> Documentation/devicetree/bindings/sound/adi,adau17x1.txt
> Documentation/devicetree/bindings/sound/adi,ssm2305.txt
> Documentation/devicetree/bindings/sound/adi,adau1701.txt
> Documentation/devicetree/bindings/sound/adi,axi-spdif-tx.txt
> Documentation/devicetree/bindings/sound/adi,ssm2602.txt
> Documentation/devicetree/bindings/mux/adi,adgs1408.txt
> Documentation/devicetree/bindings/mux/adi,adg792a.txt
> Documentation/devicetree/bindings/dma/adi,axi-dmac.txt
> Documentation/devicetree/bindings/hwmon/adi,adm1266.yaml
> Documentation/devicetree/bindings/hwmon/adi,axi-fan-control.yaml
> Documentation/devicetree/bindings/hwmon/adi,adm1177.yaml
> Documentation/devicetree/bindings/hwmon/adi,ltc2947.yaml

These might be different entries, different subsystems. Even if
devices in hwmon could be similar to iio, but sound is something else.

Best regards,
Krzysztof