Re: [PATCH] RDMA/ucma: Fix resource leak on error path

From: Alex Dewar
Date: Thu Sep 03 2020 - 05:35:14 EST


On Wed, Sep 02, 2020 at 07:34:26PM -0500, Gustavo A. R. Silva wrote:
> Hi Alex,
>
> On 9/2/20 11:24, Alex Dewar wrote:
> > In ucma_process_join(), if the call to xa_alloc() fails, the function
> > will return without freeing mc. Fix this by jumping to the correct line.
> >
> > In the process I renamed the jump labels to something more memorable for
> > extra clarity.
> >
> > Addresses-Coverity: ("Resource leak")
>
> If you are using a public Coverity scan, please also include the Coverity ID.
> In this case ID 1496814, something like:
>
> Addresses-Coverity-ID: 1496814 ("Resource leak")

Ahh ok. Thanks for the pointer :)
>
> People that don't include an CID is because they are using a private Coverity
> scan, so it doesn't make sense for them to add an ID because no one but
> them have access to that scan report.
>
> Thanks
> --
> Gustavo
>