Re: [PATCH v11 00/11] PCI: brcmstb: enable PCIe for STB chips

From: Lorenzo Pieralisi
Date: Tue Sep 08 2020 - 06:44:08 EST


On Mon, Sep 07, 2020 at 11:29:06AM -0700, Florian Fainelli wrote:
>
>
> On 9/7/2020 10:43 AM, Jim Quinlan wrote:
> > On Mon, Sep 7, 2020 at 5:16 AM Lorenzo Pieralisi
> > <lorenzo.pieralisi@xxxxxxx> wrote:
> > >
> > > On Thu, Aug 27, 2020 at 09:29:59AM -0400, Jim Quinlan wrote:
> > > > On Thu, Aug 27, 2020 at 2:35 AM Christoph Hellwig <hch@xxxxxx> wrote:
> > > > >
> > > > > On Tue, Aug 25, 2020 at 10:40:27AM -0700, Florian Fainelli wrote:
> > > > > > Hi,
> > > > > >
> > > > > > On 8/24/2020 12:30 PM, Jim Quinlan wrote:
> > > > > > >
> > > > > > > Patchset Summary:
> > > > > > > Enhance a PCIe host controller driver. Because of its unusual design
> > > > > > > we are foced to change dev->dma_pfn_offset into a more general role
> > > > > > > allowing multiple offsets. See the 'v1' notes below for more info.
> > > > > >
> > > > > > We are version 11 and counting, and it is not clear to me whether there is
> > > > > > any chance of getting these patches reviewed and hopefully merged for the
> > > > > > 5.10 merge window.
> > > > > >
> > > > > > There are a lot of different files being touched, so what would be the
> > > > > > ideal way of routing those changes towards inclusion?
> > > > >
> > > > > FYI, I offered to take the dma-mapping bits through the dma-mapping tree.
> > > > > I have a bit of a backlog, but plan to review and if Jim is ok with that
> > > > > apply the current version.
> > > > Sounds good to me.
> > >
> > > Hi Jim,
> > >
> > > is the dependency now solved ? Should we review/take this series as
> > > is for v5.10 through the PCI tree ?
> > Hello Lorenzo,
> >
> > We are still working out a regression with the DMA offset commit on
> > the RaspberryPi. Nicolas has found the root cause and we are now
> > devising a solution.
>
> Maybe we can parallelize the PCIe driver review while the DMA changes
> are being worked on in Christoph's branch. Lorenzo, are you fine with
> the PCIe changes proper?

I will have a look - the main contentious point was about the DMA
changes - if Christoph is happy with them I am OK with them
too - I hope there is not anything controversial in the host
bridge driver itself but I will look into it.

Lorenzo