Re: [PATCH 04/12] x86/platform/uv: Update UV MMRs for UV5
From: Mike Travis
Date: Tue Sep 08 2020 - 12:28:32 EST
On 9/8/2020 8:44 AM, Greg KH wrote:
On Tue, Sep 08, 2020 at 08:35:37AM -0700, Mike Travis wrote:
On 9/8/2020 8:23 AM, Greg KH wrote:
On Mon, Sep 07, 2020 at 01:54:34PM -0500, Mike Travis wrote:
--- linux.orig/drivers/misc/sgi-gru/grufile.c
+++ linux/drivers/misc/sgi-gru/grufile.c
@@ -7,7 +7,8 @@
* This file supports the user system call for file open, close, mmap, etc.
* This also incudes the driver initialization code.
*
- * Copyright (c) 2008-2014 Silicon Graphics, Inc. All Rights Reserved.
+ * Copyright (c) 2018-2020 Hewlett Packard Enterprise Development LP
+ * Copyright (c) 2008-2017 Silicon Graphics, Inc. All Rights Reserved.
Please drop all copyright changes from this series, as these do not look
correct at all, sorry.
You can send an add-on patch for all of that if it's really necessary,
and you get legal approval for it :)
I can move them all to a single patch. The HPE one is straight from their
guidance on Copyrights. The older SGI one is also from SGI's guidance
though I'm not sure if I can find it anymore. I also wasn't sure if it
should be retained since the HPE one didn't take effect until SGI was
legally part of HPE (circa 2018). 2017/18 was also the last time we did
this big a change (for the UV4A).
If you haven't touched a file in a year, you don't get to claim
copyright on that year. If you wish to disagree on this, great, I'll
gladly take a patch that modifies the lines that has a signed-off-by
from one of your lawyers for it :)
I skipped over that part. But I'm moving all changes to a single patch
and I will look more closely at HPE's documents. Heaven knows they have
plenty of lawyers, so many it's hard to ask a simple question... like
when does a copyright take effect. When you change it internally, or
when it gets published? Sounds like you lean towards the second?
Thanks,
Mike
thanks,
greg k-h