Re: Question: Why is there no notification when a file is opened using filp_open()?

From: Matthew Wilcox
Date: Tue Sep 08 2020 - 13:19:29 EST


On Tue, Sep 08, 2020 at 04:18:29PM +0300, Amir Goldstein wrote:
> On Tue, Sep 8, 2020 at 3:53 PM Xiaoming Ni <nixiaoming@xxxxxxxxxx> wrote:
> > For example, in fs/coredump.c, do_coredump() calls filp_open() to
> > generate core files.
> > In this scenario, the fsnotify_open() notification is missing.
>
> I am not convinced that we should generate an event.
> You will have to explain in what is the real world use case that requires this
> event to be generated.

Take the typical usage for fsnotify of a graphical file manager.
It would be nice if the file manager showed a corefile as soon as it
appeared in a directory rather than waiting until some other operation
in that directory caused those directory contents to be refreshed.