Re: drivers: mfd: lm3533: Support for DT bindings

From: Lee Jones
Date: Wed Sep 09 2020 - 03:29:03 EST


On Thu, 03 Sep 2020, SUNGOLD wrote:

> Hi, I am a high school student and a Linux enthusiast and for my free time,
> I'm trying to mainline a spare device I had, it's a Xiaomi Mi 4i
> (xiaomi-ferrari), till now I've got some basic bringup (had to bring up
> touchscreen Atmel mXT336T using the downstream driver as the mainlined
> generic atmel_mxt_ts.c has no support, so committed a sin
> <https://github.com/SUNGOLDSV/msm8916-mainline-linux/commit/6280fdb9750b1dc40dd4d769118d8ba71cbb0a0d>
> ;)
>
> I'm currently working on implementing backlight for my panel and it uses
> LM3533 for it's backlight and notification LEDS.
>
> I tried to find any dt-bindings docs about it and I finally found a patch
> <http://patchwork.ozlabs.org/project/devicetree-bindings/patch/20161226181153.11271-1-bjorn.andersson@xxxxxxxxxx/#1545653>
> that was rejected and I followed it in hopes of initialising the driver,
> and it didn't work out as it was not even initialising.
>
> With me having almost no knowledge of C, I tried to understand the
> `lm3533-core.c` while reading some docs on building a linux driver, and my
> interpretation is that the driver was not written for devices that use DTS
> and it was actually written for devices that use a board config file such
> as imx arm based devices.
>
> Now I request you to add support for devices that use DTS or I might have
> to commit another sin ;)
>
> My Github repo <https://github.com/SUNGOLDSV/msm8916-mainline-linux>
>
> Thanking you
> sungold
> p.s. just asking for advice and help, this is my first mail to a dev and a
> mailing list

Good morning,

Thanks for reaching out.

I think your best bet is to follow-up with Bjorn (now Cc'ed).

Keep up the good work.

Kind regards,
Lee

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog