Re: [PATCH v2] brcmsmac: fix memory leak in wlc_phy_attach_lcnphy

From: Kalle Valo
Date: Wed Sep 09 2020 - 03:32:54 EST


Keita Suzuki <keitasuzuki.park@xxxxxxxxxxxxxxxxxxxx> wrote:

> When wlc_phy_txpwr_srom_read_lcnphy fails in wlc_phy_attach_lcnphy,
> the allocated pi->u.pi_lcnphy is leaked, since struct brcms_phy will be
> freed in the caller function.
>
> Fix this by calling wlc_phy_detach_lcnphy in the error handler of
> wlc_phy_txpwr_srom_read_lcnphy before returning.
>
> Signed-off-by: Keita Suzuki <keitasuzuki.park@xxxxxxxxxxxxxxxxxxxx>

Patch applied to wireless-drivers-next.git, thanks.

f4443293d741 brcmsmac: fix memory leak in wlc_phy_attach_lcnphy

--
https://patchwork.kernel.org/patch/11763749/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches