Re: [PATCH 27/29] ath9k: ar5008_initvals: Move ar5416Bank{0,1,2,3,7} to where they are used

From: Lee Jones
Date: Thu Sep 10 2020 - 13:09:24 EST


On Thu, 10 Sep 2020, Kalle Valo wrote:

> Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/net/wireless/ath/ath9k/ar5008_initvals.h:627:18: warning: ‘ar5416Bank7’ defined but not used [-Wunused-const-variable=]
> > 627 | static const u32 ar5416Bank7[][2] = {
> > | ^~~~~~~~~~~
> > drivers/net/wireless/ath/ath9k/ar5008_initvals.h:548:18: warning: ‘ar5416Bank3’ defined but not used [-Wunused-const-variable=]
> > 548 | static const u32 ar5416Bank3[][3] = {
> > | ^~~~~~~~~~~
> > drivers/net/wireless/ath/ath9k/ar5008_initvals.h:542:18: warning: ‘ar5416Bank2’ defined but not used [-Wunused-const-variable=]
> > 542 | static const u32 ar5416Bank2[][2] = {
> > | ^~~~~~~~~~~
> > drivers/net/wireless/ath/ath9k/ar5008_initvals.h:536:18: warning: ‘ar5416Bank1’ defined but not used [-Wunused-const-variable=]
> > 536 | static const u32 ar5416Bank1[][2] = {
> > | ^~~~~~~~~~~
> > drivers/net/wireless/ath/ath9k/ar5008_initvals.h:462:18: warning: ‘ar5416Bank0’ defined but not used [-Wunused-const-variable=]
> > 462 | static const u32 ar5416Bank0[][2] = {
> > | ^~~~~~~~~~~
> >
> > Cc: QCA ath9k Development <ath9k-devel@xxxxxxxxxxxxxxxx>
> > Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> > Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> > Cc: linux-wireless@xxxxxxxxxxxxxxx
> > Cc: netdev@xxxxxxxxxxxxxxx
> > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
>
> Already fixed in ath.git.

Ah, this is the repo that takes a while to filter into -next?

NP, thanks.

> error: patch failed: drivers/net/wireless/ath/ath9k/ar5008_initvals.h:459
> error: drivers/net/wireless/ath/ath9k/ar5008_initvals.h: patch does not apply
> error: patch failed: drivers/net/wireless/ath/ath9k/ar5008_phy.c:18
> error: drivers/net/wireless/ath/ath9k/ar5008_phy.c: patch does not apply
> stg import: Diff does not apply cleanly
>
> Patch set to Rejected.
>

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog