Re: [RFC PATCH v2 1/3] mm/gup: fix gup_fast with dynamic page table folding

From: peterz
Date: Fri Sep 11 2020 - 03:11:21 EST


On Thu, Sep 10, 2020 at 06:59:21PM -0300, Jason Gunthorpe wrote:
> So, I suggest pXX_offset_unlocked()

Urgh, no. Elsewhere in gup _unlocked() means it will take the lock
itself (get_user_pages_unlocked()) -- although often it seems to mean
the lock is already held (git grep _unlocked and marvel).

What we want is _lockless().