Re: [PATCH v2] spi: spi-nxp-fspi: Add ACPI support

[Ard Biesheuvel]

On 9/11/20 1:00 PM, Mark Brown wrote:
> On Fri, Sep 11, 2020 at 01:58:06PM +0530, kuldip dwivedi wrote:
>
> >   	/* find the resources - configuration register address space */
> >   	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "fspi_base");
> > +#ifdef CONFIG_ACPI
> > +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > +#endif
>
> This is buggy, it is equivalent to just removing the name based lookup
> since we'll do the name based lookup then unconditionally overwrite the
> results with an index based lookup.

Also, note that CONFIG_ACPI kernels may still boot in DT mode.