Re: [PATCH net-next RFC v4 01/15] devlink: Add reload action option to devlink reload command

From: Michael Chan
Date: Mon Sep 14 2020 - 18:06:46 EST


On Mon, Sep 14, 2020 at 2:31 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Mon, 14 Sep 2020 13:28:29 +0200 Jiri Pirko wrote:
> > >> Instead, why don't you block in reload_up() until the reset is complete?
> > >
> > >Though user initiate "devlink dev reload" event on a single interface,
> > >all driver entities undergo reset and all entities recover
> > >independently. I don't think we can block the reload_up() on the
> > >interface(that user initiated the command), until whole reset is
> > >complete.
> >
> > Why not? mlxsw reset takes up to like 10 seconds for example.
>
> +1, why?

Yes, we should be able to block until the reset sequence is complete.
I don't see any problem. I will work with Vasundhara on this.