Re: [PATCH -next] soc: renesas: r8a779a0-sysc: Make r8a779a0_sysc_info static

[Geert Uytterhoeven]

Hi Yue,

On Tue, Sep 15, 2020 at 4:58 PM YueHaibing <yuehaibing@xxxxxxxxxx> wrote:
> Fix sparse warning:
>
> drivers/soc/renesas/r8a779a0-sysc.c:99:33: warning: symbol 'r8a779a0_sysc_info' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Thanks for your patch!

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

As commit 7f29315cf4211316 ("soc: renesas: r8a779a0-sysc: Add r8a779a0
support") hasn't been merged into arm-soc yet, is it OK for you if I
just fold your fix into the original commit?

Thanks again!

> --- a/drivers/soc/renesas/r8a779a0-sysc.c
> +++ b/drivers/soc/renesas/r8a779a0-sysc.c
> @@ -96,7 +96,7 @@ static struct r8a779a0_sysc_area r8a779a0_areas[] __initdata = {
>         { "a1dsp1",     R8A779A0_PD_A1DSP1, R8A779A0_PD_A2CN1 },
>  };
>
> -const struct r8a779a0_sysc_info r8a779a0_sysc_info __initconst = {
> +static const struct r8a779a0_sysc_info r8a779a0_sysc_info __initconst = {
>         .areas = r8a779a0_areas,
>         .num_areas = ARRAY_SIZE(r8a779a0_areas),
>  };

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds