Re: [PATCH 1/2] sparc32: Move ioremap/iounmap declaration before asm-generic/io.h include

From: Christoph Hellwig
Date: Tue Sep 15 2020 - 20:07:01 EST


> diff --git a/arch/sparc/include/asm/io_32.h b/arch/sparc/include/asm/io_32.h
> index 9a52d9506f80..042201c79ad1 100644
> --- a/arch/sparc/include/asm/io_32.h
> +++ b/arch/sparc/include/asm/io_32.h
> @@ -11,6 +11,16 @@
> #define memcpy_fromio(d,s,sz) _memcpy_fromio(d,s,sz)
> #define memcpy_toio(d,s,sz) _memcpy_toio(d,s,sz)
>
> +#ifdef __KERNEL__
> +
> +/*
> + * Bus number may be embedded in the higher bits of the physical address.
> + * This is why we have no bus number argument to ioremap().
> + */
> +void __iomem *ioremap(phys_addr_t offset, size_t size);
> +void iounmap(volatile void __iomem *addr);
> +#endif

No need for an __KERNEL__ in non-uapi headers.