Re: [PATCH 1/3] arm64: dts: meson-axg: add VPU and PWRC nodes

From: Neil Armstrong
Date: Wed Sep 16 2020 - 03:12:51 EST


On 15/09/2020 21:50, Martin Blumenstingl wrote:
> Hi Neil,
>
> On Mon, Sep 7, 2020 at 10:33 AM Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
>>
>> This add the display VPU node and the power controller PWRC node.
> s/add/adds/
>
>> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> Acked-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
>
> [...]
>> + vpu: vpu@ff900000 {
>> + compatible = "amlogic,meson-axg-vpu";
>> + reg = <0x0 0xff900000 0x0 0x100000>,
>> + <0x0 0xff63c000 0x0 0x1000>;
> my plan is to replace the "hhi" binding with a reference to the HHI
> syscon - but at the same time I'm not sure if it's a good idea (or
> whether for example CVBS support should be split off into a sub-driver
> which is then part of the HHI MFD syscon).

It's also my plan, yes until we get 100% rid of HHI access from DRM driver,
we still need it.

It you want to push it, please do it !

Neil

> maybe we can align at some point about the next steps with the the DRM
> driver (as I want to add support for the older gen SoCs still)
> that's nothing for this patch though
>
>
> Best regards,
> Martin
>