Re: [PATCH next v2] gpiolib: check for parent device in devprop_gpiochip_set_names()

From: Mika Westerberg
Date: Thu Sep 17 2020 - 06:02:48 EST


On Thu, Sep 17, 2020 at 09:48:57AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
>
> It's possible for a GPIO chip to not have a parent device (whose
> properties we inspect for 'gpio-line-names'). In this case we should
> simply return from devprop_gpiochip_set_names(). Add an appropriate
> check for this use-case.
>
> Fixes: 7cba1a4d5e16 ("gpiolib: generalize devprop_gpiochip_set_names() for device properties")
> Reported-by: Anders Roxell <anders.roxell@xxxxxxxxxx>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Tested-by: Anders Roxell <anders.roxell@xxxxxxxxxx>

FWIW,

Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>