Re: [PATCH v2 09/13] dt-bindings: pinctrl: include common schema in GPIO controllers

From: Krzysztof Kozlowski
Date: Fri Sep 18 2020 - 04:19:44 EST


On Thu, 17 Sep 2020 at 22:12, Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
>
> Hi Krzysztof,
>
> Thank you for the patch.
>
> On Thu, Sep 17, 2020 at 06:52:57PM +0200, Krzysztof Kozlowski wrote:
> > Include the common GPIO schema in GPIO controllers to be sure all common
> > properties are properly validated.
>
> Shouldn't we delete the properties that are now redundant from these
> schemas ?

Good point. However not with "additionalPropeties: false". Schema
requires all properties to be mentioned. I would need to use
"unevaluatedProperties: false" in each file.

What is preferred?

Best regards,
Krzysztof