Re: [PATCH -next] tty: hvc: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n

From: Greg KH
Date: Fri Sep 18 2020 - 07:16:40 EST


On Fri, Sep 18, 2020 at 05:20:30PM +0800, Yang Yingliang wrote:
> Fix the link error by selecting SERIAL_CORE_CONSOLE.
>
> aarch64-linux-gnu-ld: drivers/tty/hvc/hvc_dcc.o: in function `dcc_early_write':
> hvc_dcc.c:(.text+0x164): undefined reference to `uart_console_write'
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> ---
> drivers/tty/hvc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/hvc/Kconfig b/drivers/tty/hvc/Kconfig
> index d1b27b0522a3..8d60e0ff67b4 100644
> --- a/drivers/tty/hvc/Kconfig
> +++ b/drivers/tty/hvc/Kconfig
> @@ -81,6 +81,7 @@ config HVC_DCC
> bool "ARM JTAG DCC console"
> depends on ARM || ARM64
> select HVC_DRIVER
> + select SERIAL_CORE_CONSOLE
> help
> This console uses the JTAG DCC on ARM to create a console under the HVC
> driver. This console is used through a JTAG only on ARM. If you don't have
> --
> 2.25.1
>

Same question here, what caused this problem to happen?

thanks,

greg k-h