Re: [PATCH v2 35/37] kasan, slub: reset tags when accessing metadata

From: Marco Elver
Date: Fri Sep 18 2020 - 10:44:35 EST


On Tue, Sep 15, 2020 at 11:16PM +0200, Andrey Konovalov wrote:
[...]
> static void set_track(struct kmem_cache *s, void *object,
> @@ -583,7 +585,8 @@ static void set_track(struct kmem_cache *s, void *object,
> unsigned int nr_entries;
>
> metadata_access_enable();
> - nr_entries = stack_trace_save(p->addrs, TRACK_ADDRS_COUNT, 3);
> + nr_entries = stack_trace_save(kasan_reset_tag(p->addrs),
> + TRACK_ADDRS_COUNT, 3);

Suggested edit (below 100 cols):

- nr_entries = stack_trace_save(kasan_reset_tag(p->addrs),
- TRACK_ADDRS_COUNT, 3);
+ nr_entries = stack_trace_save(kasan_reset_tag(p->addrs), TRACK_ADDRS_COUNT, 3);