答复: [PATCH net-next] net: ethernet: Remove set but not used variable

From: zhengyongjun
Date: Fri Sep 18 2020 - 21:46:53 EST


I have fix it and send back the patch to you. Thank you very much.

-----邮件原件-----
发件人: David Miller [mailto:davem@xxxxxxxxxxxxx]
发送时间: 2020年9月19日 5:30
收件人: zhengyongjun <zhengyongjun3@xxxxxxxxxx>
抄送: fmanlunas@xxxxxxxxxxx; sburla@xxxxxxxxxxx; dchickles@xxxxxxxxxxx; kuba@xxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
主题: Re: [PATCH net-next] net: ethernet: Remove set but not used variable

From: Zheng Yongjun <zhengyongjun3@xxxxxxxxxx>
Date: Fri, 18 Sep 2020 16:39:38 +0800

> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/cavium/liquidio/octeon_device.c: In function lio_pci_readq:
> drivers/net/ethernet/cavium/liquidio/octeon_device.c:1327:6: warning: variable ʽval32ʼ set but not used [-Wunused-but-set-variable]
>
> drivers/net/ethernet/cavium/liquidio/octeon_device.c: In function lio_pci_writeq:
> drivers/net/ethernet/cavium/liquidio/octeon_device.c:1358:6: warning: variable ʽval32ʼ set but not used [-Wunused-but-set-variable]
>
> these variable is never used, so remove it.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@xxxxxxxxxx>

The proper subsystem prefix for these changes is just "liquidio: ".

For changes to a specific driver it is not appropriate to use
"net: ethernet: " or similar.

Please fix up your Subject line and resubmit.

Thank you.