Re: [PATCH 3/3] objtool: check: Handle calling non-function symbols in other sections

From: Josh Poimboeuf
Date: Mon Sep 21 2020 - 10:40:25 EST


On Mon, Sep 21, 2020 at 10:56:05AM +0100, Julien Thierry wrote:
>
>
> On 9/18/20 9:07 PM, Josh Poimboeuf wrote:
> > On Tue, Sep 15, 2020 at 08:53:18AM +0100, Julien Thierry wrote:
> > > Relocation for a call destination could point to a symbol that has
> > > type STT_NOTYPE.
> >
> > Then shouldn't the callee be changed to STT_FUNC?
> >
>
> Not if it's a code symbol that does not follow standard calling convention.
>
> It's really the same case as the !reloc, except this time it's in a
> different .text section.

Yeah, that makes sense. I'll take this one as well.

--
Josh