Re: [PATCH 11/42] mfd: intel_soc_pmic: use PLATFORM_DEVID_NONE

[Andy Shevchenko]

On Mon, Sep 21, 2020 at 11:54 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
>  - it brings some meaning,
>  - it might point attention why auto device ID was not used.

Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> ---
>  drivers/mfd/intel_soc_pmic_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c
> index ddd64f9e3341..b7bbe58dedcc 100644
> --- a/drivers/mfd/intel_soc_pmic_core.c
> +++ b/drivers/mfd/intel_soc_pmic_core.c
> @@ -86,7 +86,7 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c,
>         /* Add lookup table for crc-pwm */
>         pwm_add_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup));
>
> -       ret = mfd_add_devices(dev, -1, config->cell_dev,
> +       ret = mfd_add_devices(dev, PLATFORM_DEVID_NONE, config->cell_dev,
>                               config->n_cell_devs, NULL, 0,
>                               regmap_irq_get_domain(pmic->irq_chip_data));
>         if (ret)
> --
> 2.17.1
>


-- 
With Best Regards,
Andy Shevchenko