Re: [PATCH] ARM: dts: exynos: revert "add input clock to CMU in Exynos4412 Odroid"

From: Krzysztof Kozlowski
Date: Tue Sep 22 2020 - 11:57:12 EST


On Mon, Sep 21, 2020 at 07:48:18PM +0200, Krzysztof Kozlowski wrote:
> This reverts commit eaf2d2f6895d676dda6c95a652b58594f2887720.
>
> The commit eaf2d2f6895d ("ARM: dts: exynos: add input clock to CMU in
> Exynos4412 Odroid") breaks probing of usb3503 USB hub on Odroid U3.
>
> It changes the order of clock drivers probe: the clkout (Exynos PMU)
> driver is probed before the main clk-exynos4 driver. The clkout driver
> on Exynos4412 depends on clk-exynos4 but it does not support deferred
> probe, therefore this dependency and changed probe order causes probe
> failure.
>
> The usb3503 USB hub on Odroid U3 on the other hand requires clkout
> clock. This can be seen in logs:
>
> [ 5.007442] usb3503 0-0008: unable to request refclk (-517)
>
> Reported-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> ---
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 1 -

Applied.

Best regards,
Krzysztof