Re: [PATCH -next] net/mlx5: simplify the return expression of mlx5_ec_init()

From: Saeed Mahameed
Date: Tue Sep 22 2020 - 15:53:05 EST


On Tue, 2020-09-22 at 08:04 -0700, Jakub Kicinski wrote:
> On Mon, 21 Sep 2020 22:52:30 -0700 Saeed Mahameed wrote:
> > On Mon, 2020-09-21 at 21:10 +0800, Qinglang Miao wrote:
> > > Simplify the return expression.
> > >
> > > Signed-off-by: Qinglang Miao <miaoqinglang@xxxxxxxxxx>
> > > ---
> > > drivers/net/ethernet/mellanox/mlx5/core/ecpf.c | 6 +-----
> > > 1 file changed, 1 insertion(+), 5 deletions(-)
> > >
> > >
> >
> > Applied to net-next-mlx5.
>
> Beware:
>
> drivers/net/ethernet/mellanox/mlx5/core/ecpf.c: In function
> ‘mlx5_ec_init’:
> drivers/net/ethernet/mellanox/mlx5/core/ecpf.c:46:6: warning: unused
> variable ‘err’ [-Wunused-variable]
> 46 | int err = 0;
> | ^~~

Thanks Jakub

Yes, Saw this in my CI as well,
will resolve this one myself.
and for next time I will wait for the CI result before replying ;)