Re: [PATCH] clk: tegra: Drop !provider check in tegra210_clk_emc_set_rate()

From: Thierry Reding
Date: Wed Sep 23 2020 - 04:23:55 EST


On Tue, Sep 22, 2020 at 12:16:41PM -0700, Stephen Boyd wrote:
> The provider variable is already dereferenced earlier in this function.
> Drop the check for NULL as it is impossible.
>
> Found with smatch
>
> drivers/clk/tegra/clk-tegra210-emc.c:131 tegra210_clk_emc_set_rate() warn: variable dereferenced before check 'provider' (see line 124)
>
> Cc: Joseph Lo <josephl@xxxxxxxxxx>
> Cc: Thierry Reding <treding@xxxxxxxxxx>
> Fixes: 0ac65fc946d3 ("clk: tegra: Implement Tegra210 EMC clock")
> Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxx>
> ---
> drivers/clk/tegra/clk-tegra210-emc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Thierry Reding <treding@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature