Re: [PATCH v38 18/24] x86/vdso: Add support for exception fixup in vDSO functions

From: Jarkko Sakkinen
Date: Thu Sep 24 2020 - 17:07:25 EST


On Thu, Sep 24, 2020 at 06:00:57PM +0200, Borislav Petkov wrote:
> On Thu, Sep 24, 2020 at 03:09:01PM +0300, Jarkko Sakkinen wrote:
> > This is not technically SGX specific patch. Is SGX documentation the
> > correct place for this?
>
> So what is it then? It is SGX implementation-specific. Why would you not
> put it in the documentation?!
>
> > From checkpatch I only get:
>
> Please concentrate and start reading more carefully:
>
> ".git/rebase-apply/patch:122: new blank line at EOF."
>
> Would that error come from checkpatch?

Nope. And I did fully read what you wrote. I just mentioned that more in
the tone that I should (and will) do also git am test from now on, at
least for mainline tree (when applicable) and x86 tip.

Right now the static tests that I do are checkpatch and sparse. Any
other suggestions are welcome.

I would also also coccicheck but have had some version issues with it in
Ubuntu, which I use as my host OS. Cannot recall what was the exact
issue, has been a while since I last tried it.

> --
> Regards/Gruss,
> Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette

/Jarkko