Re: [PATCH v6 1/9] kernel: Support TIF_SYSCALL_INTERCEPT flag

From: Gabriel Krisman Bertazi
Date: Fri Sep 25 2020 - 12:16:01 EST


Thomas Gleixner <tglx@xxxxxxxxxxxxx> writes:

> On Wed, Sep 23 2020 at 13:49, Kees Cook wrote:
>> On Wed, Sep 23, 2020 at 04:18:26PM -0400, Gabriel Krisman Bertazi wrote:
>>> Kees Cook <keescook@xxxxxxxxxxxx> writes:
>>> Yes, we can, and I'm happy to follow up with that as part of my TIF
>>> clean up work, but can we not block the current patchset to be merged
>>> waiting for that, as this already grew a lot from the original feature
>>> submission?
>>
>> In that case, I'd say just add the new TIF flag. The consolidation can
>> come later.
>
> No. This is exactly the wrong order. Cleanup and consolidation have
> precedence over features. I'm tired of 'we'll do that later' songs,
> simply because in the very end I'm going to be the idiot who mops up the
> resulting mess.
>

No problem. I will follow up with a patchset consolidating those flags
into this syscall_intercept interface I proposed. I assume there is no
immediate concerns with the consolidation approach itself.

--
Gabriel Krisman Bertazi