Re: [PATCH 15/42] mfd: max14577: use PLATFORM_DEVID_NONE

From: Chanwoo Choi
Date: Sun Sep 27 2020 - 23:03:04 EST


On 9/22/20 5:49 AM, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
> - it brings some meaning,
> - it might point attention why auto device ID was not used.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> ---
> drivers/mfd/max14577.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c
> index be185e9d5f16..93df79748a45 100644
> --- a/drivers/mfd/max14577.c
> +++ b/drivers/mfd/max14577.c
> @@ -445,7 +445,7 @@ static int max14577_i2c_probe(struct i2c_client *i2c,
> goto err_max77836;
> }
>
> - ret = mfd_add_devices(max14577->dev, -1, mfd_devs,
> + ret = mfd_add_devices(max14577->dev, PLATFORM_DEVID_NONE, mfd_devs,
> mfd_devs_size, NULL, 0, NULL);
> if (ret < 0)
> goto err_mfd;
>

Acked-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>

--
Best Regards,
Chanwoo Choi
Samsung Electronics