Re: [PATCH v6 4/4] Bluetooth: Add toggle to switch off interleave scan

From: Jakub Kicinski
Date: Mon Sep 28 2020 - 15:45:11 EST


On Mon, 28 Sep 2020 15:41:21 +0800 Howard Chung wrote:
> This patch add a configurable parameter to switch off the interleave
> scan feature.
>
> Signed-off-by: Howard Chung <howardchung@xxxxxxxxxx>
> Reviewed-by: Alain Michaud <alainm@xxxxxxxxxxxx>

This seems to cause new warnings on W=1 C=1 builds:

In file included from ../net/bluetooth/mgmt_config.c:7:
net/bluetooth/mgmt_config.c: In function ‘set_def_system_config’:
include/net/bluetooth/bluetooth.h:186:10: warning: format ‘%zu’ expects argument of type ‘size_t’, but argument 4 has type ‘int’ [-Wformat=]
186 | BT_WARN("%s: " fmt, (hdev)->name, ##__VA_ARGS__)
| ^~~~~~
include/net/bluetooth/bluetooth.h:174:35: note: in definition of macro ‘BT_WARN’
174 | #define BT_WARN(fmt, ...) bt_warn(fmt "\n", ##__VA_ARGS__)
| ^~~
net/bluetooth/mgmt_config.c:165:4: note: in expansion of macro ‘bt_dev_warn’
165 | bt_dev_warn(hdev, "invalid length %d, exp %zu for type %d",
| ^~~~~~~~~~~
net/bluetooth/mgmt_config.c:79:17: warning: incorrect type in initializer (different base types)
net/bluetooth/mgmt_config.c:79:17: expected restricted __le16 [usertype] type
net/bluetooth/mgmt_config.c:79:17: got int
net/bluetooth/mgmt_config.c:79:17: warning: incorrect type in initializer (different base types)
net/bluetooth/mgmt_config.c:79:17: expected restricted __le16 [usertype] value_le16
net/bluetooth/mgmt_config.c:79:17: got unsigned char [usertype]