Re: [PATCH 2/6] dt-bindings: can: mcp25xxfd: document device tree bindings

From: Geert Uytterhoeven
Date: Tue Sep 29 2020 - 05:46:49 EST


Hi Manivannan, Oleksij,

On Thu, Sep 10, 2020 at 11:37 PM Manivannan Sadhasivam
<manivannan.sadhasivam@xxxxxxxxxx> wrote:
> From: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
>
> This patch adds the device-tree binding documentation for the Microchip
> MCP25xxFD SPI CAN controller family.
>
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>

Thanks for your patch, which is now commit 1b5a78e69c1fdae9
("dt-binding: can: mcp25xxfd: document device tree bindings") in net-next.

> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/can/microchip,mcp25xxfd.yaml
> @@ -0,0 +1,79 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/can/microchip,mcp25xxfd.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title:
> + Microchip MCP2517FD and MCP2518FD stand-alone CAN controller device tree
> + bindings
> +
> +maintainers:
> + - Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: microchip,mcp2517fd
> + description: for MCP2517FD
> + - const: microchip,mcp2518fd
> + description: for MCP2518FD
> + - const: microchip,mcp25xxfd
> + description: to autodetect chip variant

The last one is a wildcard?
When would you want to use it (oh, in the example below)?
Can you guarantee Microchip will not introduce other components that
match this wildcard, but are not compatible?

Gr{oetje,eeting}s,

Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds