Re: [PATCH][next] net/mlx5e: Fix potential null pointer dereference

From: Gustavo A. R. Silva
Date: Tue Sep 29 2020 - 09:08:20 EST


On Mon, Sep 28, 2020 at 04:22:33PM -0700, Saeed Mahameed wrote:
> On Fri, 2020-09-25 at 11:49 -0500, Gustavo A. R. Silva wrote:
> > Calls to kzalloc() and kvzalloc() should be null-checked
> > in order to avoid any potential failures. In this case,
> > a potential null pointer dereference.
> >
> > Fix this by adding null checks for _parse_attr_ and _flow_
> > right after allocation.
> >
> > Addresses-Coverity-ID: 1497154 ("Dereference before null check")
> > Fixes: c620b772152b ("net/mlx5: Refactor tc flow attributes
> > structure")
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> > ---
> >
>
> Applied to net-next-mlx5.

Thank you both. :)
--
Gustavo