Re: [PATCH v2] ipvs: Add traffic statistic up even it is VS/DR or VS/TUN mode

From: Jakub Kicinski
Date: Tue Sep 29 2020 - 10:41:53 EST


On Tue, 29 Sep 2020 16:18:11 +0800 longguang.yue wrote:
> @@ -411,10 +413,17 @@ struct ip_vs_conn *ip_vs_conn_out_get(const struct ip_vs_conn_param *p)
> rcu_read_lock();
>
> hlist_for_each_entry_rcu(cp, &ip_vs_conn_tab[hash], c_list) {
> - if (p->vport == cp->cport && p->cport == cp->dport &&
> + if (IP_VS_FWD_METHOD(cp) != IP_VS_CONN_F_MASQ){
> + cport = cp->vport;

checkpatch says:

ERROR: space required before the open brace '{'
#25: FILE: net/netfilter/ipvs/ip_vs_core.c:1416:
+ if (IP_VS_FWD_METHOD(cp) != IP_VS_CONN_F_MASQ){