Re: [PATCH] pinctrl: single: check if #pinctrl-cells exceeds 3

From: Tony Lindgren
Date: Wed Sep 30 2020 - 01:17:06 EST


* Linus Walleij <linus.walleij@xxxxxxxxxx> [200929 12:51]:
> On Sun, Sep 13, 2020 at 11:17 PM Drew Fustini <drew@xxxxxxxxxxxxxxx> wrote:
>
> > The property #pinctrl-cells can either be 2 or 3. There is currently
> > only a check to make sure that #pinctrl-cells is 2 or greater. This
> > patch adds a check to make sure it is not greater than 3.
> >
> > Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2")
> > Reported-by: Trent Piepho <tpiepho@xxxxxxxxx>
> > Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/
> > Signed-off-by: Drew Fustini <drew@xxxxxxxxxxxxxxx>
>
> Tony, does this and the other patch look good to you?

Hmm well the description looks a bit confusing, #pinctrl-cells can
also be 1 that's the default. Might be worth clarifying that part.

Regards,

Tony