Re: Keyboard regression by intel-vbtn

From: Hans de Goede
Date: Wed Sep 30 2020 - 09:21:55 EST


Hi,

On 9/29/20 10:48 AM, Takashi Iwai wrote:
Hi Hans,

it seems that the recent update of intel-vtn broke the keyboard input
on some laptops with libinput:
https://bugzilla.opensuse.org/show_bug.cgi?id=1175599

Blacklisting intel-vtn fixes the issue, so it's likely the falsely
reported tablet mode switch that leads libinput misbehaving. The
affected machines are Acer E5-511 and ASUS X756UX laptops, and they
shouldn't have the tablet mode at all, AFAIK.

Could you take a look? I guess it's the commit cfae58ed681c that
broke. The chassis type is Notebook on those, and this type should be
excluded as well as Laptop.

The dmidecode outputs and other info are found in the bugzilla above:
https://bugzilla.opensuse.org/attachment.cgi?id=841999
https://bugzilla.opensuse.org/attachment.cgi?id=842039

The one for ASUS is embedded in hwinfo outpt:
https://bugzilla.opensuse.org/attachment.cgi?id=841157

Ok, you should have just received a patch fixing this, sorry
that creating it took a bit longer then I had hoped.

Andy, can you drop the:

"platform/x86: intel-vbtn: Fix SW_TABLET_MODE always reporting 1 on the HP Pavilion 11 x360"

Patch from your review-andy branch, plug in the new one and
then send it out to Linus for merging into 5.9 please ?

Regards,

Hans