Re: [RFC PATCH v2 1/2] objtool: x86 instruction decoder and big endian cross compiles

From: Josh Poimboeuf
Date: Wed Sep 30 2020 - 11:20:02 EST


On Wed, Sep 30, 2020 at 02:24:19PM +0200, Vasily Gorbik wrote:
> From: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
>
> Make the x86 instruction decoder of the objtool usable on big endian
> machines. This is useful for compile tests on non x86, big endian
> hardware.
>
> Co-developed-by: Vasily Gorbik <gor@xxxxxxxxxxxxx>
> [ gor: more endianness problems findings fixes / rebasing ]
> Signed-off-by: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> Signed-off-by: Vasily Gorbik <gor@xxxxxxxxxxxxx>
> ---
> arch/x86/include/asm/insn.h | 42 ++++++++++++++
> arch/x86/lib/insn.c | 95 +++++++++++++------------------
> tools/arch/x86/include/asm/insn.h | 42 ++++++++++++++
> tools/arch/x86/lib/insn.c | 95 +++++++++++++------------------
> tools/objtool/arch/x86/special.c | 2 +-
> tools/objtool/check.c | 4 +-
> tools/objtool/elf.c | 34 ++++++-----
> 7 files changed, 188 insertions(+), 126 deletions(-)

Can the insn changes be done in a separate patch from the objtool
changes?

Also, 'Masami Hiramatsu <mhiramat@xxxxxxxxxx>' should be on Cc for the
insn changes since he wrote the original code.

--
Josh