Re: [PATCH v3 0/2] Add support for F3A

From: Lyude Paul
Date: Wed Sep 30 2020 - 16:17:40 EST


For the whole series:

Reviewed-by: Lyude Paul <lyude@xxxxxxxxxx>

On Wed, 2020-09-30 at 17:41 +0800, Vincent Huang wrote:
> RMI4 F3A supports the touchpad GPIO function, it's designed to support
> more GPIOs and used on newer touchpads. The patches add support of
> touchpad buttons and rename f30_data to avoid confusion.
>
> Changes in v2:
> - Combined patch 1 and 2 of v1 to fix bisectability.
>
> Changes in v3:
> - Fix indentations pointed out by Lyude Paul.
>
> Vincent Huang (2):
> Input: synaptics-rmi4 - rename f30_data to gpio_data
> Input: synaptics-rmi4 - add support for F3A
>
> drivers/hid/hid-rmi.c | 2 +-
> drivers/input/mouse/synaptics.c | 2 +-
> drivers/input/rmi4/Kconfig | 8 ++
> drivers/input/rmi4/Makefile | 1 +
> drivers/input/rmi4/rmi_bus.c | 3 +
> drivers/input/rmi4/rmi_driver.h | 1 +
> drivers/input/rmi4/rmi_f30.c | 14 +-
> drivers/input/rmi4/rmi_f3a.c | 240 ++++++++++++++++++++++++++++++++
> include/linux/rmi.h | 11 +-
> 9 files changed, 268 insertions(+), 14 deletions(-)
> create mode 100644 drivers/input/rmi4/rmi_f3a.c
>
--
Sincerely,
Lyude Paul (she/her)
Software Engineer at Red Hat