Re: [PATCH 1/2] certs: Move load_system_certificate_list to a common function

From: Jarkko Sakkinen
Date: Wed Sep 30 2020 - 17:49:58 EST


On Wed, Sep 30, 2020 at 03:15:10PM -0600, Eric Snowberg wrote:
>
> > On Sep 30, 2020, at 3:02 PM, Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx> wrote:
> >
> > On Wed, Sep 30, 2020 at 04:15:07PM -0400, Eric Snowberg wrote:
> >> Move functionality within load_system_certificate_list to a common
> >> function, so it can be reused in the future.
> >>
> >> Signed-off-by: Eric Snowberg <eric.snowberg@xxxxxxxxxx>
> >
> > I rather think now rather than the future. I think this should be part
> > of a patch set where the re-use actually happens.
>
> load_certificate_list is being used in the second patch in the series [1].
> It uses the now common code, to load the revocation certificates, just like
> the system certificates are being loaded in this patch.

Ugh, better to get some sleep. Double checked 2/2 and ack still holds.
Sorry about this.

Acked-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>

/Jarkko