Re: [PATCH 1/2] dt-bindings: drm/bridge: ti-sn65dsi86: Replace #pwm-cells

From: Steev Klimaszewski
Date: Wed Sep 30 2020 - 19:07:28 EST



On 9/30/20 5:35 PM, Bjorn Andersson wrote:
> While the signal on GPIO4 to drive the backlight controller indeed is
> pulse width modulated its purpose is specifically to control the
> brightness of a backlight.
>
> Drop the #pwm-cells and instead expose a new property to configure the
> granularity of the backlight PWM signal.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> ---
> .../devicetree/bindings/display/bridge/ti,sn65dsi86.yaml | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml
> index f8622bd0f61e..e380218b4646 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml
> @@ -66,9 +66,12 @@ properties:
> 1-based to match the datasheet. See ../../gpio/gpio.txt for more
> information.
>
> - '#pwm-cells':
> - const: 1
> - description: See ../../pwm/pwm.yaml for description of the cell formats.
> + ti,backlight-scale:
> + description:
> + The granularity of brightness for the PWM signal provided on GPIO4, if
> + this property is specified.
> + minimum: 0
> + maximum: 65535
>
> ports:
> type: object


Tested-By: Steev Klimaszewski <steev@xxxxxxxx>