Re: [PATCH v4] tools lib traceevent: Hide non API functions

From: Arnaldo Carvalho de Melo
Date: Wed Sep 30 2020 - 21:33:54 EST


Em Wed, Sep 30, 2020 at 12:50:27PM -0400, Steven Rostedt escreveu:
> On Wed, 30 Sep 2020 14:07:33 +0300
> "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@xxxxxxxxx> wrote:
>
> > There are internal library functions, which are not declared as a static.
> > They are used inside the library from different files. Hide them from
> > the library users, as they are not part of the API.
> > These functions are made hidden and are renamed without the prefix "tep_":
> > tep_free_plugin_paths
> > tep_peek_char
> > tep_buffer_init
> > tep_get_input_buf_ptr
> > tep_get_input_buf
> > tep_read_token
> > tep_free_token
> > tep_free_event
> > tep_free_format_field
> > __tep_parse_format
> >
> > Link: https://lore.kernel.org/linux-trace-devel/e4afdd82deb5e023d53231bb13e08dca78085fb0.camel@xxxxxxxxxxxxxxx/
> > Reported-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> > Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@xxxxxxxxx>
> > ---
>
> Reviewed-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
>
> Arnaldo,
>
> Can you pull this in?

Sure, I was just waiting for this to get to some conclusion.

- Arnaldo