Re: [PATCH v4 1/4] mm: memcontrol: use helpers to access page's memcg data

From: Johannes Weiner
Date: Thu Oct 01 2020 - 09:48:24 EST


On Wed, Sep 30, 2020 at 05:27:07PM -0700, Roman Gushchin wrote:
> +/*
> + * set_page_memcg - associate a page with a memory cgroup
> + * @page: a pointer to the page struct
> + * @memcg: a pointer to the memory cgroup
> + *
> + * Associates a page with a memory cgroup.
> + */
> +static inline void set_page_memcg(struct page *page, struct mem_cgroup *memcg)
> +{
> + VM_BUG_ON_PAGE(PageSlab(page), page);
> +
> + /*
> + * Please, refer to page_memcg()'s description for the page and memcg
> + * binding stability requirements.
> + */
> + page->memcg_data = (unsigned long)memcg;
> +}

Please delete and inline this as per previous feedback, thanks.