Re: [PATCH v1] i2c: npcm7xx: Support changing bus speed using debugfs.

From: Andy Shevchenko
Date: Thu Oct 01 2020 - 11:40:25 EST


On Thu, Oct 1, 2020 at 8:34 AM Tali Perry <tali.perry1@xxxxxxxxx> wrote:
> On Wed, Sep 30, 2020 at 12:31 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> >
> > On Wed, Sep 30, 2020 at 10:13:42AM +0300, Tali Perry wrote:
> > > Systems that can dinamically add and remove slave devices
> >
> > dynamically
> >
> > > often need to change the bus speed in runtime.
> >
> > > This patch exposes the bus frequency to the user.
> >
> > Expose the bus frequency to the user.
> >
> > > This feature can also be used for test automation.
> >
> > In general I think that DT overlays or so should be user rather than this.
> > If we allow to change bus speed settings for debugging purposes it might make
> > sense to do this on framework level for all drivers which support that (via
> > additional callback or so).
>
> Do you mean adding something like this:

Nope. I meant to use DT description for that. I²C core should cope
with DT already.
I do not understand why you need special nodes for that rather than DT
overlay which will change the speed for you.

--
With Best Regards,
Andy Shevchenko