Re: [PATCH v6 3/7] dt-bindings: mfd: Fix schema warnings for pwm-leds

From: Alexander Dahl
Date: Fri Oct 02 2020 - 06:07:51 EST


Hello Krzysztof,

Am Freitag, 2. Oktober 2020, 11:21:10 CEST schrieb Krzysztof Kozlowski:
> On Thu, 1 Oct 2020 at 01:51, Alexander Dahl <post@xxxxxxxxxxx> wrote:
> > The node names for devices using the pwm-leds driver follow a certain
> > naming scheme (now).
>
> What warning? Please post them here and in every DTS patch.

ack

> Your schema does not enforce pwmleds node naming (the main node, not
> children), or at least I could not see it. You change multiple files
> in your patchset so are you sure that all these are justified by
> warnings pointed out by schema?

The rename was suggested by Rob [1], and I think you're right, those names are
not (yet) enforced by schema? So at least the commit message is misleading
for now. I'll have to see if I rather reword or update the schema again.

Greets
Alex

[1] https://lore.kernel.org/linux-leds/20200922155747.GA2734659@bogus/