Re: [PATCH] arm64: dts: meson: add SM1 soundcard name to VIM3L

From: Jerome Brunet
Date: Fri Oct 02 2020 - 10:44:29 EST



On Fri 02 Oct 2020 at 16:16, Christian Hewitt <christianshewitt@xxxxxxxxx> wrote:

> VIM3L now inherits the sound node from the VIM3 common dtsi but is
> an SM1 device, so label it as such, and stop users blaming future
> support issues on the distro/app "wrongly detecting" their device.
>
> Signed-off-by: Christian Hewitt <christianshewitt@xxxxxxxxx>
> ---
> arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
> index 4b517ca72059..f46f0ecc37ec 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
> @@ -32,6 +32,10 @@
> regulator-boot-on;
> regulator-always-on;
> };
> +
> + sound {
> + model = "SM1-KHADAS-VIM3L";
> + };

The sound card is the same so I don't see why the sm1 board should have
a different name. If you are not happy with the name, please update it
in the common file.

> };
>
> &cpu0 {