Re: [PATCH net-next] mptcp: ADD_ADDRs with echo bit are smaller

From: David Miller
Date: Sat Oct 03 2020 - 20:36:51 EST


From: Matthieu Baerts <matthieu.baerts@xxxxxxxxxxxx>
Date: Sat, 3 Oct 2020 17:36:56 +0200

> The MPTCP ADD_ADDR suboption with echo-flag=1 has no HMAC, the size is
> smaller than the one initially sent without echo-flag=1. We then need to
> use the correct size everywhere when we need this echo bit.
>
> Before this patch, the wrong size was reserved but the correct amount of
> bytes were written (and read): the remaining bytes contained garbage.
>
> Fixes: 6a6c05a8b016 ("mptcp: send out ADD_ADDR with echo flag")
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/95
> Reported-and-tested-by: Davide Caratti <dcaratti@xxxxxxxxxx>
> Acked-by: Geliang Tang <geliangtang@xxxxxxxxx>
> Signed-off-by: Matthieu Baerts <matthieu.baerts@xxxxxxxxxxxx>

Applied.