Re: [PATCH AUTOSEL 5.8 28/29] spi: fsl-dspi: fix use-after-free in remove path

[Sasha Levin]

On Tue, Sep 29, 2020 at 08:22:16AM +0200, Sascha Hauer wrote:
> Hi Sasha,
>
> On Mon, Sep 28, 2020 at 09:30:25PM -0400, Sasha Levin wrote:
> > From: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> >
> > [ Upstream commit 530b5affc675ade5db4a03f04ed7cd66806c8a1a ]
> >
> > spi_unregister_controller() not only unregisters the controller, but
> > also frees the controller. This will free the driver data with it, so
> > we must not access it later dspi_remove().
> >
> > Solve this by allocating the driver data separately from the SPI
> > controller.
> >
> > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> > Link: https://lore.kernel.org/r/20200923131026.20707-1-s.hauer@xxxxxxxxxxxxxx
> > Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> > ---
> >  drivers/spi/spi-fsl-dspi.c | 12 +++++++-----
> >  1 file changed, 7 insertions(+), 5 deletions(-)
>
> This patch causes a regression and shouldn't be applied without the fix
> in https://lkml.org/lkml/2020/9/28/300.

Looks like the fix didn't make it yet, so I'll drop the patch.

--
Thanks,
Sasha