Re: [PATCH] printk: handle blank console arguments passed in.

From: Sergey Senozhatsky
Date: Tue Oct 06 2020 - 13:15:10 EST


On (20/10/06 18:35), Petr Mladek wrote:
> > > Whatever is decided, I'd like to have it made official and documented to
> > > avoid a similar problem in the future.
>
> Sigh, it is even bigger mess than I expected. There is a magic
> variable "console_set_on_cmdline". It used, for example, in
> of_console_check() to prevent using the default console from dts.

I wonder if we can do something like:

---
@@ -2200,6 +2200,9 @@ static int __init console_setup(char *str)
char *s, *options, *brl_options = NULL;
int idx;

if (str[0] == 0) {
+ console_set_on_cmdline = 1;
return 1;
}

if (_braille_console_setup(&str, &brl_options))
return 1;
---

-ss