Re: [PATCH v4 02/13] x86/platform/uv: Remove SCIR MMR references for UVY systems.

From: Mike Travis
Date: Tue Oct 06 2020 - 21:11:44 EST


On 10/6/2020 6:16 AM, Borislav Petkov wrote:
Subject: Re: [PATCH v4 02/13] x86/platform/uv: Remove SCIR MMR references for UVY systems.

You mean "UV" systems, right? Or are there "UVY" systems too? git grep
says no.

I thought there was more references to the UVY class which currently has only UV5 as a member. There might be UV5 references where they should be UVY. The struct references use "uvy" as the selector so the grep should look for upper and lower case.

The UV5 system is still in the design stage so we are doing development using simulators. More UV5 support is expected to arrive as needed. (The earlier class was UVX if interested.)

On Mon, Oct 05, 2020 at 03:39:18PM -0500, Mike Travis wrote:
UV class systems no longer use System Controller for monitoring of CPU
activity provided by this driver. Other methods have been developed
for BIOS and the management controller (BMC). This patch removes that
supporting code.

Avoid having "This patch" or "This commit" in the commit message. It is
tautologically useless.

Also, do

$ git grep 'This patch' Documentation/process >
for more details.

I've fixed it up but please try not to do that in future patches.

Will do, thanks for the update it has been awhile for me.

Thx.