Re: [PATCH] gpio: pca953x: Survive spurious interrupts

From: Andy Shevchenko
Date: Wed Oct 07 2020 - 08:01:28 EST


On Wed, Oct 7, 2020 at 12:49 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> On Mon, Oct 5, 2020 at 4:02 PM Marc Zyngier <maz@xxxxxxxxxx> wrote:
>
> > The pca953x driver never checks the result of irq_find_mapping(),
> > which returns 0 when no mapping is found. When a spurious interrupt
> > is delivered (which can happen under obscure circumstances), the
> > kernel explodes as it still tries to handle the error code as
> > a real interrupt.
> >
> > Handle this particular case and warn on spurious interrupts.
> >
> > Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx>

Wait, doesn't actually [1] fix the reported issue?
Marc, can you confirm this?

[1]: e43c26e12dd4 ("gpio: pca953x: Fix uninitialized pending variable")


--
With Best Regards,
Andy Shevchenko