Re: [PATCH v7 3/3] PCI: uniphier: Add misc interrupt handler to invoke PME and AER

From: Rob Herring
Date: Wed Oct 07 2020 - 12:46:03 EST


On Fri, 11 Sep 2020 18:33:34 +0900, Kunihiko Hayashi wrote:
> This patch adds misc interrupt handler to detect and invoke PME/AER event.
>
> In UniPhier PCIe controller, PME/AER signals are assigned to the same
> signal as MSI by the internal logic. These signals should be detected by
> the internal register, however, DWC MSI handler can't handle these signals.
>
> DWC MSI handler calls .msi_host_isr() callback function, that detects
> PME/AER signals with the internal register and invokes the interrupt
> with PME/AER vIRQ numbers.
>
> These vIRQ numbers is obtained from portdrv in uniphier_add_pcie_port()
> function.
>
> Cc: Marc Zyngier <maz@xxxxxxxxxx>
> Cc: Jingoo Han <jingoohan1@xxxxxxxxx>
> Cc: Gustavo Pimentel <gustavo.pimentel@xxxxxxxxxxxx>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
> ---
> drivers/pci/controller/dwc/pcie-uniphier.c | 77 +++++++++++++++++++++++++-----
> 1 file changed, 66 insertions(+), 11 deletions(-)
>

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>